Fix GEM Offline DQM for GE2/1 Demonstrator #36883

seungjin-yang · 2022-02-04T08:49:36Z

PR description:

This PR fixes MonitorElement: WARNING:setBinLabel caused by GEM offline DQM not handling the new GEM geometry with GE2/1 demonstrator. See #36860 (comment).

PR validation:

This PR is tested with 12034.0 using the following script.

CMSSW_BASE=CMSSW_12_3_X_2022-02-03-2300
SCRAM_ARCH=slc7_amd64_gcc10 cmsrel ${CMSSW_BASE}
cd ${CMSSW_BASE}/src
git-cms-merge-topic seungjin-yang:GEM-Offline-DQM-with-GE21-Demonstrator__from-CMSSW_12_3_X_2022-02-03-2300
git-cms-merge-topic francescobrivio:alca-FixGEMsuperchamber_12_3_X
runTheMatrix.py -l 12034.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport. However, It will be backported to 12_2_X as mentioned in #36860 (comment)

seungjin-yang · 2022-02-04T08:51:33Z

@jshlee, @watson-ij

cmsbuild · 2022-02-04T08:56:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36883/28146

This PR adds an extra 24KB to repository

cmsbuild · 2022-02-04T08:57:17Z

A new Pull Request was created by @seungjin-yang (Seungjin Yang) for master.

It involves the following packages:

DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2022-02-04T08:59:48Z

please test

perrotta · 2022-02-04T09:00:31Z

please abort

perrotta · 2022-02-04T09:02:17Z

please test with #36860

perrotta · 2022-02-04T10:17:32Z

urgent

cmsbuild · 2022-02-04T13:04:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7b7d/22220/summary.html
COMMIT: 17682ea
CMSSW: CMSSW_12_3_X_2022-02-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36883/22220/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764894
DQMHistoTests: Total failures: 101
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3764771
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -6.342 KiB( 45 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 1.448 KiB GEM/Digis
DQMHistoSizes: changed ( 11634.0,... ): 0.855 KiB GEM/Efficiency
DQMHistoSizes: changed ( 11634.0,... ): 0.849 KiB GEM/SimHits
DQMHistoSizes: changed ( 11634.0,... ): 0.531 KiB GEM/Pad
DQMHistoSizes: changed ( 11634.0,... ): 0.432 KiB GEM/PadCluster
DQMHistoSizes: changed ( 11634.0,... ): 0.299 KiB GEM/RecHits
DQMHistoSizes: changed ( 11634.911 ): -32.826 KiB GEM/Efficiency
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

perrotta · 2022-02-05T08:21:40Z

please abort

perrotta · 2022-02-05T08:22:34Z

please test

cmsbuild · 2022-02-05T12:20:53Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7b7d/22243/summary.html
COMMIT: d0a1df0
CMSSW: CMSSW_12_3_X_2022-02-04-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36883/22243/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 32 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3765080
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3765037
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -235.774 KiB( 45 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -33.682 KiB GEM/Efficiency
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

jfernan2 · 2022-02-07T12:08:30Z

+1

cmsbuild · 2022-02-07T12:08:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-07T12:22:14Z

+1

The warnings from the GEMEfficiencyAnalyzer disappear from the logs with this fix

perrotta · 2022-02-07T12:24:04Z

@seungjin-yang could you please prepare a backport for 12_2_X?

seungjin-yang · 2022-02-07T14:39:48Z

@seungjin-yang could you please prepare a backport for 12_2_X?

#36904 (backport of #36627) must be merged into 12_2_X first for a backport of this PR. I will create a backport of this PR as soon as #36904 is merged,

perrotta · 2022-02-07T15:45:42Z

@seungjin-yang CMSSW_12_2_X is supposedly a closed release cycle: we can't backport things on it only for the sake of doing so.
Now, due to the missing pieces in the Run3 geometry as integrated in the original 12_2_0 we are forced to backport the new Run3 MC geometry in 12_2_X, together with all adjustments needed to allow producing and validating the samples with it.
As far as I understand, this PR is a fix needed if we want to run the GEM validation with the new Run3 geometry in 12_2. Whatever else which is not strictly necessary shouldn't get backported into a closed release.
If you think that something else needs to be backported, please try to justify it here. Or, alternatively, if you don't think that this PR can fix anything currently broken in 12_2 + backported Run3 geometry, please disregard my request of backporting it (but explain us why we won't hit in 12_2 the bug that you are fixing here).

seungjin-yang · 2022-02-07T16:29:54Z

@perrotta Okay I see. I will create a backport of this PR without a backport (#36904) of #36627. Also, I will close #36904.

…1-Demonstrator__from-CMSSW_12_2_X_2022-02-06-2300 Fix GEM Offline DQM for GE2/1 Demonstrator (backport of #36883, 12_2_X)

seungjin-yang added 2 commits February 4, 2022 15:25

Add flags to enable/disable monitoring for GEM stations.

20f0367

apply code-format

17682ea

cmsbuild added this to the CMSSW_12_3_X milestone Feb 4, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Feb 4, 2022

seungjin-yang changed the title ~~Gem offline dqm with ge21 demonstrator from cmssw 12 3 x 2022 02 03 2300~~ Fix GEM Offline DQM for GE2/1 Demonstrator Feb 4, 2022

seungjin-yang mentioned this pull request Feb 4, 2022

Update GEM reco geometry for Run3 MC GTs #36860

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 4, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 4, 2022

cmsbuild added tests-pending and removed tests-started labels Feb 4, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Feb 4, 2022

cmsbuild added the urgent label Feb 4, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 4, 2022

cmsbuild added tests-pending and removed tests-started labels Feb 5, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 5, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 5, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Feb 7, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2022

cmsbuild merged commit 31cd4ef into cms-sw:master Feb 7, 2022

seungjin-yang mentioned this pull request Feb 7, 2022

Move GEM offline DQM files from DQMOffline/Muon to DQM/GEM (backport of #36627, CMSSW_12_2_X) #36904

Closed

This was referenced Feb 7, 2022

Implementation of beam halo tagger algorithm for the endcap photons #36901

Merged

[HGCAL trigger] Migration to new code structure - First pass #36337

Merged

[ROOT master] Updated root to tip of branch master cms-sw/cmsdist#7601

Merged

seungjin-yang mentioned this pull request Feb 8, 2022

Fix GEM Offline DQM for GE2/1 Demonstrator (backport of #36883, 12_2_X) #36906

Merged

cmsbuild added a commit that referenced this pull request Feb 8, 2022

Merge pull request #36906 from seungjin-yang/GEM-Offline-DQM-with-GE2…

3662f17

…1-Demonstrator__from-CMSSW_12_2_X_2022-02-06-2300 Fix GEM Offline DQM for GE2/1 Demonstrator (backport of #36883, 12_2_X)

seungjin-yang mentioned this pull request Jun 11, 2022

GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GEM Offline DQM for GE2/1 Demonstrator #36883

Fix GEM Offline DQM for GE2/1 Demonstrator #36883

seungjin-yang commented Feb 4, 2022

seungjin-yang commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

perrotta commented Feb 5, 2022

perrotta commented Feb 5, 2022

cmsbuild commented Feb 5, 2022

jfernan2 commented Feb 7, 2022

cmsbuild commented Feb 7, 2022

perrotta commented Feb 7, 2022

perrotta commented Feb 7, 2022

seungjin-yang commented Feb 7, 2022 •

edited

Loading

perrotta commented Feb 7, 2022

seungjin-yang commented Feb 7, 2022

Fix GEM Offline DQM for GE2/1 Demonstrator #36883

Fix GEM Offline DQM for GE2/1 Demonstrator #36883

Conversation

seungjin-yang commented Feb 4, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

seungjin-yang commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

perrotta commented Feb 4, 2022

cmsbuild commented Feb 4, 2022

Comparison Summary

perrotta commented Feb 5, 2022

perrotta commented Feb 5, 2022

cmsbuild commented Feb 5, 2022

Comparison Summary

jfernan2 commented Feb 7, 2022

cmsbuild commented Feb 7, 2022

perrotta commented Feb 7, 2022

perrotta commented Feb 7, 2022

seungjin-yang commented Feb 7, 2022 • edited Loading

perrotta commented Feb 7, 2022

seungjin-yang commented Feb 7, 2022

seungjin-yang commented Feb 7, 2022 •

edited

Loading