-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GEM Offline DQM for GE2/1 Demonstrator #36883
Fix GEM Offline DQM for GE2/1 Demonstrator #36883
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36883/28146
|
A new Pull Request was created by @seungjin-yang (Seungjin Yang) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
please abort |
please test with #36860 |
urgent |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7b7d/22220/summary.html Comparison SummarySummary:
|
please abort |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b7b7d/22243/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
@seungjin-yang could you please prepare a backport for 12_2_X? |
#36904 (backport of #36627) must be merged into 12_2_X first for a backport of this PR. I will create a backport of this PR as soon as #36904 is merged, |
@seungjin-yang CMSSW_12_2_X is supposedly a closed release cycle: we can't backport things on it only for the sake of doing so. |
…1-Demonstrator__from-CMSSW_12_2_X_2022-02-06-2300 Fix GEM Offline DQM for GE2/1 Demonstrator (backport of #36883, 12_2_X)
PR description:
This PR fixes
MonitorElement: WARNING:setBinLabel
caused by GEM offline DQM not handling the new GEM geometry with GE2/1 demonstrator. See #36860 (comment).PR validation:
This PR is tested with
12034.0
using the following script.if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport. However, It will be backported to 12_2_X as mentioned in #36860 (comment)